Add ObsidianSetCheckbox (Attempt)
#802
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-eckert
force-pushed
the
t-eckert/add-set-checkbox
branch
from
0d68c91 to
1b214e5
Compare
rodrigoscc
reviewed
Jan 22, 2025
|
|
||
| if string.match(line, checkbox_pattern) then | ||
| -- Only set the check_char if the line contains the checkbox pattern. | ||
| line = util.string_replace(line, "- [" .. check_char .. "]", "- [" .. check_char .. "]", 1) |
There was a problem hiding this comment.
The issue seems to be here. You are trying to replace say - [ x ] with - [ x ], so doing nothing. You need to replace - [ <anything> ] with - [ <check_char> ].
There was a problem hiding this comment.
You could extract <anything> with the regex checkbox_pattern, just make the char a regex group and extract it.
There was a problem hiding this comment.
Thank you! I'll make this fix and test again. Great catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @epwalsh, I just started using your plugin today. It's fantastic!
I wanted to map an
ObsidianSetCheckbox xto check off items for my day. Toggle is great, but it's not specifically what I want to use.This is my best attempt at adding the feature after I saw that #781 was asking for the same functionality.
I'm definitely missing something. I can run the command, but it doesn't do anything.
If you want this feature, please let me know what I can do to get this over the finish line for you. Feel free to close otherwise.