Host API implementation and runtime updates #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to launch core_version runtime method. Added memory related classes.
# Conflicts: # core/src/runtime/service.cpp
asmie
approved these changes
Nov 15, 2022
core/src/host/api.h
Outdated
| } | ||
| } | ||
| std::shared_ptr<plc::core::runtime::Memory> m_memory; | ||
| std::map<soralog::Level, int> m_wasm_log_level_map; |
There was a problem hiding this comment.
m_wasm_log_level_map looks like something constant (the map is initialized with const values in constructor in api.cpp file) - it's only searched and retrieved values.
So it could be at least const (or even maybe constexpr).
Well, it could be thought about using unordered_map as it would speed up the looking log level in ext_logging_max_level_version_1 method and possibility of element collision is none. Ordering seems also to not matter.
| } | ||
|
|
||
| wasm::Literals ExternalInterface::callImport(wasm::Function* import, wasm::LiteralList& arguments) { | ||
| if (import->module == env) { |
kylegranger
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
4 host API methods were implemented which are called by the
Core_versionruntime call:ext_logging_max_level_version_1ext_logging_log_version_1ext_allocator_malloc_version_1ext_allocator_free_version_1I've also added memory management (based on Kagome code) - this was needed by both
ext_allocator...methods. Currently it is possible to runCore_versionand get the resulting Version struct - however it is missing decoding of the APIs as this requires implementing blake2 algorithms which is out of this task scope. It should be straightforward now to implement other host and runtime methods.