Add tests #51
Add tests #51
Conversation
| import io.swagger.v3.oas.models.parameters.Parameter; | ||
| import io.swagger.v3.oas.models.parameters.Parameter.StyleEnum; | ||
| import io.swagger.v3.parser.OpenAPIV3Parser; | ||
| import io.swagger.v3.oas.models.OpenAPI; |
There was a problem hiding this comment.
There's too much changing just because of whitespace modifications. I don't know which lines you've changed because there are 3,375 lines changed and most of them are whitespace. Your PRs need to just include whichever details you've actually changed. There shouldn't be whitespace modifications like this.
Cannot review until the PR is limited to only the lines that you've changed.
There was a problem hiding this comment.
I've came back to previous formatting so you have changes what I needed only :)
| @@ -0,0 +1,548 @@ | |||
| {{>licenseInfo}} | |||
There was a problem hiding this comment.
Which lines in this file are different than the base template? Can you provide information about why this was included and what it supports in your solution?
There was a problem hiding this comment.
108, 120, 130,134 - gson requires to register some class to serialize/deserialize in the proper way.
| @@ -1,61 +0,0 @@ | |||
| # This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time | |||
There was a problem hiding this comment.
Why is this workflow being removed? Please provide justification for changes. I don't have enough context to understand the changes you're making. Either provide smaller separate PRs or provide a lot more context to me so that I can understand the changes you're making.
There was a problem hiding this comment.
it was replaced by new flow to run tests for commit which will provide the code is compilible and prove that tests are good
| @@ -1,98 +0,0 @@ | |||
| package com.equinix.openapi.fabric.v4.api; | |||
There was a problem hiding this comment.
Is the folder v4/api all completely manually added by you? No code generation?
I don't know how this will be able to keep up because it's pulling a lot of code generated files over to it that are subject to change causing lots of overhead when updating tests.
There was a problem hiding this comment.
this class had been removed. these files must be located in separated folder because that is the java code structure. tests must be placed in defined place to run in during different maven command like test, package, publish etc. api code library generates only frames for each group of endpoints and they are without implementation
v4/api/dto/TokenRequestDto.java
Outdated
| return this; | ||
| } | ||
| } | ||
| public class TokenRequestDto{ |
There was a problem hiding this comment.
Why can't you leverage the code generation file for this? Why is it that you've hard copied so many files?
There was a problem hiding this comment.
I explained in another comment
added sleep app path for the report updated url removed variable from flow added new tests added generating report for tests added tests added dtos for test data
created method to generate random vlanNumber
# Conflicts: # equinix-openapi-fabric/src/test/java/com/equinix/openapi/fabric/v4/api/ConnectionsApiTest.java
# Conflicts: # equinix-openapi-fabric/src/main/java/com/equinix/openapi/fabric/v4/model/CustomField.java # equinix-openapi-fabric/src/main/java/com/equinix/openapi/fabric/v4/model/Port.java
equinix-openapi-fabric/src/main/java/com/equinix/openapi/fabric/ApiClient.java
Outdated
Show resolved
Hide resolved
No description provided.