Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes :
Introduction of patch 09 : Href schema model poses an issue where it is valid for most other models in anyOf scenario, hence by disabling allow additional properties we can fix this. This topic was discussed in a previous thread : Fix patches #61 (comment)
Introduction of patch 10, issue in
InterconnectionPort
schema :InterconnectionPort schema contains
virtual_circuits
attribute as a property:ref : https://github.com/equinix-labs/metal-java/blob/main/spec/oas3.fetched/openapi/public/components/schemas/InterconnectionPort.yaml
Whereas VirtualCircuitList represents a complex anyOf array for attribute named
virtual_circuits
:ref : https://github.com/equinix-labs/metal-java/blob/main/spec/oas3.fetched/openapi/public/components/schemas/VirtualCircuitList.yaml
This creates a incorrect response expectation which looks like this :
Patch 10 create a file called InterconnectionPortCore.yaml file without
virtual_circuits
and uses allOf to merge this new file and VirtualCircuitList.yaml to create InterconnectionPort.yaml which gives the correct response flavour.