New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme and improve functionality and clarity of the module #12

Merged

cprivitere merged 22 commits into main from update-readme

Oct 7, 2024

Member

cprivitere commented Aug 30, 2024

This is a PR to track the updates to the README.md to make it fit our terraform module standards as well as have updated deployment instructions.

cprivitere changed the title ~~feat: Update readme to have our standard terraform-docs format and first draft of workflow~~ Update README.sh to have our standard terraform-docs format and first draft of workflow

cprivitere force-pushed the update-readme branch from 7a549fa to 0f74959 Compare

August 30, 2024 21:50

cprivitere mentioned this pull request

Fix readme linting issues #16

Merged

displague reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

displague reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

displague reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

displague reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

cprivitere force-pushed the update-readme branch from 0f74959 to 7545ba6 Compare

September 3, 2024 16:09

cprivitere changed the title ~~Update README.sh to have our standard terraform-docs format and first draft of workflow~~ Update README.md to have our standard terraform-docs format and first draft of workflow

cprivitere force-pushed the update-readme branch from 7545ba6 to b0aad73 Compare

September 3, 2024 16:41

cprivitere force-pushed the update-readme branch from c43bfd9 to d885be2 Compare

September 12, 2024 18:21

displague reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

ctreatma reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

cprivitere force-pushed the update-readme branch 2 times, most recently from c369854 to 8c10220 Compare

September 27, 2024 18:24

cprivitere marked this pull request as ready for review

September 27, 2024 21:24

cprivitere force-pushed the update-readme branch 2 times, most recently from 255ccac to dbec909 Compare

September 30, 2024 20:59

ctreatma reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

ctreatma reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

ctreatma reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

cprivitere and others added 9 commits

October 1, 2024 15:08


          feat: Update readme to have our standard terraform-docs format and fi…

2171cbf

…rst draft of workflow

Signed-off-by: Chris Privitere <[email protected]>


          docs: various linting updates

f4e4762

- update tf docs section
- section renames
- remove blockquotes

Signed-off-by: Chris Privitere <[email protected]>


          docs: remove tfenv line

73ff648

Signed-off-by: Chris Privitere <[email protected]>


          docs: rename fabric_client_id and fabric_client_secret to equinix_cli…

a8f16eb

…ent_id and equinix_client_secret

Signed-off-by: Chris Privitere <[email protected]>


          docs: revise esxi/cloudbuilder login section

67df05b

Signed-off-by: Chris Privitere <[email protected]>


          docs: Update README.md

314e7c1

Replace template text which snuck in during a rebase

Co-authored-by: Marques Johansson <[email protected]>


          refactor README.md to CONTRIBUTING.md and examples/

4f89b52

Signed-off-by: Marques Johansson <[email protected]>


          fix: use correct esxi_plan name

4cb3d10

Signed-off-by: Chris Privitere <[email protected]>


          use generic names for esxi_devices indices

5f2043c

Signed-off-by: Chris Privitere <[email protected]>

cprivitere added 2 commits

October 1, 2024 15:08


          refactor: remove equinix_client_id and equinix_client_secret as they'…

2f94af2

…re no longer used

Signed-off-by: Chris Privitere <[email protected]>


          chore: move example out of this PR

120e6a1

Signed-off-by: Chris Privitere <[email protected]>

cprivitere force-pushed the update-readme branch from dbec909 to 120e6a1 Compare

October 1, 2024 20:09


          docs: clarify deployment steps

17b7bba

- Mention all steps that should be run on management host
- Mention how to get management host IP
- Mention correct username/password to use for ESX

Signed-off-by: Chris Privitere <[email protected]>

ctreatma reviewed

View reviewed changes

README.md Show resolved Hide resolved

cprivitere added 2 commits

October 2, 2024 11:09


          feat: remove esxi_server_dns variable as we're configuring DNS on the…

08c9c3a

… bastion host

Signed-off-by: Chris Privitere <[email protected]>


          fix: add dot to esx01 address

fe96726

Signed-off-by: Chris Privitere <[email protected]>

ctreatma previously approved these changes

View reviewed changes

Contributor

ctreatma left a comment

I was able to get as far as validating the spreadsheet with Cloud Builder using these docs, and my concerns about the post-terraform steps have been addressed. Looks good to me!

cprivitere added 2 commits

October 2, 2024 16:02


          fix: use configured vmware machine hostnames

85963a7

Signed-off-by: Chris Privitere <[email protected]>


          docs: add outputs to guide user better

180e214

Signed-off-by: Chris Privitere <[email protected]>

cprivitere dismissed ctreatma’s stale review via

180e214

October 2, 2024 21:03

cprivitere marked this pull request as draft

October 2, 2024 21:04

cprivitere added 5 commits

October 2, 2024 17:24


          feat: remove esxi_ntp_server from main module and use bastion host

162e970

Signed-off-by: Chris Privitere <[email protected]>


          feat: generate variuos config from input variables

8d1fb70

- this makes bastion userdata generated from values in tfvars file
- renames esxi_domain to zone_name to align with spreadsheet name for this value
- pull mgmt vlan from vrf network block
- just use bastion IP address for dns/ntp
- make windows management and bastion hostnames variables

Signed-off-by: Chris Privitere <[email protected]>


          docs: rename management to windows_management

c0c7396

Signed-off-by: Chris Privitere <[email protected]>


          docs: update terraform.tfvars.example to current

be7f693

Signed-off-by: Chris Privitere <[email protected]>


          docs: combine two lines of the deployment steps

6accd74

Signed-off-by: Chris Privitere <[email protected]>

cprivitere changed the title ~~Update README.md to have our standard terraform-docs format and first draft of workflow~~ Update Readme and improve functionality and clarity of the module

cprivitere marked this pull request as ready for review

October 4, 2024 21:05


          fix: reduce minimum size of password hash variable

Signed-off-by: Chris Privitere <[email protected]>

ctreatma approved these changes

View reviewed changes

cprivitere merged commit f113e0a into main

1 check passed

cprivitere deleted the update-readme branch

October 7, 2024 20:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet