Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MathNet.Numerics out of RvmSharp #157

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

minorai
Copy link
Collaborator

@minorai minorai commented Jul 23, 2023

First part of 3-part change to make rvmsharp useful in Unity again,

Motivation

  • Use RvmSharp in Unity
  • Prepare for improvements in tesselation, and connection detection in RvmSharp

Changes

  • none of the Math extension methods are used in rvmsharp anyway and do not belong there imho, moved to CadRvmConverter
  • changed all uint for mesh vertex indexing to int, there is little benefit of using uint (the only one being is that you cannot assign negative number, but that is not really a benefit, given that out-of-bound values are still possible), but int will remove Unity exception on internal Rvm array copy without cast, and will remove multiple linq cast throughout the code, reducing complexity
  • moved IStringInternPool to own assembly to separate implementation from interface. Snyk pleasing change in Commons is causing issues in Unity.

Testing

  • Pipeline: since this is a refactoring, all existing tests must pass, no new actual code is written yet
  • Unity: TBW

@minorai minorai requested a review from Strepto July 23, 2023 10:50
@Strepto
Copy link
Collaborator

Strepto commented Aug 14, 2023

@minorai You should fix the merge confligcts this to allow the builds to run. Rest of it seems ok to me (y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants