Removed font size multiplier #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
reviewed
Nov 13, 2024
Plugin/clScrolledPanel.cpp
Outdated
Comment on lines
385
to
388
| #elif defined(__WXMSW__) | ||
| // wxMSW | ||
| float pointSize = f.GetFractionalPointSize() * 1.2; | ||
| float pointSize = f.GetFractionalPointSize(); | ||
| f.SetFractionalPointSize(pointSize); |
There was a problem hiding this comment.
So whole __WXMSW__ block can be removed
There was a problem hiding this comment.
Something like this, i guess.
There was a problem hiding this comment.
No need to set same value for other, simply
wxFont clScrolledPanel::GetDefaultFont()
{
wxFont f = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
#if defined(__WXMAC__)
float pointSize = f.GetFractionalPointSize() * 1.2;
f.SetFractionalPointSize(pointSize);
#endif
return f;
}
or
wxFont clScrolledPanel::GetDefaultFont()
{
wxFont f = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
#if defined(__WXMAC__)
f.SetFractionalPointSize(1.2 * f.GetFractionalPointSize());
#endif
return f;
}
There was a problem hiding this comment.
Yes, really, I am setting the same value back.
Jarod42
approved these changes
Nov 14, 2024
|
Thank you! |
|
Unsure why you close your PR. Note that:
|
|
My bad, I thought it was finished. |
|
Even though some CI are failing - these were fixed in master branch. Once the Ubuntu build is OK, I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, IDE fonts in a project tree, editor tabs etc are noticeably larger than a system font. That was because an IDE font was 20% bigger than a system one. Tested it on 4K and 1080p.