Merge pull request #55 from cmc333333/static-analysis

Updates for static analysis

.codeclimate.yml

@@ -1,2 +1,18 @@
-exclude_paths:
-  - docs/*
+engines:
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - python
+  markdownlint:
+    enabled: true
+  pep8:
+    enabled: true
+  radon:
+    enabled: true
+  shellcheck:
+    enabled: true
+ratings:
+  paths:
+  - "**.py"
+exclude_paths: []

.travis.yml

@@ -14,5 +14,6 @@ install:
 script:
   - python manage.py test
   - flake8 .
+  - bandit -r .
 after_success:
     coveralls

README.md

@@ -1,8 +1,9 @@
 regulations-core
 ================
-
-[![Build Status](https://travis-ci.org/eregs/regulations-core.png)](https://travis-ci.org/eregs/regulations-core)
-[![Coverage Status](https://coveralls.io/repos/18F/regulations-core/badge.svg?branch=master&service=github)](https://coveralls.io/github/18F/regulations-core?branch=master)
+[![Build Status](https://travis-ci.org/eregs/regulations-core.svg?branch=master)](https://travis-ci.org/eregs/regulations-core)
+[![Dependency Status](https://gemnasium.com/badges/github.com/eregs/regulations-core.svg)](https://gemnasium.com/github.com/eregs/regulations-core)
+[![Coverage Status](https://coveralls.io/repos/github/eregs/regulations-core/badge.svg?branch=master)](https://coveralls.io/github/eregs/regulations-core?branch=master)
+[![Code Climate](https://codeclimate.com/github/eregs/regulations-core/badges/gpa.svg)](https://codeclimate.com/github/eregs/regulations-core)
 [![Code Issues](https://www.quantifiedcode.com/api/v1/project/0cdc7eb543724f60b428aa9cae42bd5f/badge.svg)](https://www.quantifiedcode.com/app/project/0cdc7eb543724f60b428aa9cae42bd5f)
 
 An API that provides an interface for storing and retrieving regulations,

regcore_write/views/layer.py

@@ -1,9 +1,14 @@
+import logging
+
 from regcore.db import storage
 from regcore.layer import standardize_params
 from regcore.responses import success, user_error
 from regcore_write.views.security import json_body, secure_write
 
 
+logger = logging.getLogger(__name__)
+
+
 def child_label_of(lhs, rhs):
     """Is the lhs label a child of the rhs label"""
     #   Interpretations have a slightly different hierarchy
@@ -51,10 +56,12 @@ def child_layers(layer_params, layer_data):
     doc_id_components = layer_params.doc_id.split('/')
     if layer_params.doc_type == 'preamble':
         doc_tree = storage.for_documents.get('preamble', layer_params.doc_id)
-    else:
-        assert layer_params.doc_type == 'cfr'
+    elif layer_params.doc_type == 'cfr':
         version, label = doc_id_components
         doc_tree = storage.for_documents.get('cfr', label, version)
+    else:
+        doc_tree = None
+        logger.error("Invalid doc type: %s", layer_params.doc_type)
     if not doc_tree:
         return []
 

requirements_test.txt

@@ -5,3 +5,4 @@ mock==1.3.0
 nose==1.3.7
 coverage==4.0.3
 coveralls==1.1
+git+https://github.com/openstack/bandit.git   # PyPi version is out of date