This repository has been archived by the owner on Feb 13, 2023. It is now read-only.
Range picker improve #472
Merged
Range picker improve #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 111 Still Failing |
bleto
reviewed
Jul 29, 2020
Comment on lines
114
to
124
| if (from && to) { | ||
| this.$emit('input', { | ||
| from: date, | ||
| to: null, | ||
| }); | ||
| } else if (from && date < from) { | ||
| this.$emit('input', { | ||
| from: date, | ||
| to: null, | ||
| }); | ||
| } else if (from === null) { |
There was a problem hiding this comment.
you can connect these 2 conditions because inside is that same logic.
bleto
previously approved these changes
Jul 29, 2020
bleto
previously approved these changes
Jul 29, 2020
bleto
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add advanced date range picker:
Issue # (#70)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: