Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade crypto calls to new functions #26

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Upgrade crypto calls to new functions #26

merged 1 commit into from
Jun 19, 2021

Conversation

ankhers
Copy link
Contributor

@ankhers ankhers commented Jun 17, 2021

:crypto.hmac/3 functions are no longer a gone. Should be using :crypto.mac/4 instead.

@ankhers
Copy link
Contributor Author

ankhers commented Jun 17, 2021 •
edited
Loading

This does not upgrade the dependency shopify. It looks like that project is dead.

I do have a PR against the repo though. nsweeting/shopify#104

@ericdude4
Copy link
Owner

@ankhers thanks for this! I actually plan on removing the shopfy dependency entirely. It's one of the items in the "v1" project for this repo.

I'll make a release with this change and shopify removal soon.

@ericdude4 ericdude4 merged commit 8dfd502 into ericdude4:master Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankhers @ericdude4