Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caplin: Fixed up validator's attestation rate during epoch slots #12377

Open
wants to merge 104 commits into
base: main
Choose a base branch
from
Open

Caplin: Fixed up validator's attestation rate during epoch slots #12377

wants to merge 104 commits into from

Conversation

Giulio2002
Copy link
Contributor

@Giulio2002 Giulio2002 commented Oct 20, 2024 •
edited
Loading

Fixes:

  • Optimized head retrieval in the beacon API.
  • Optimized GetHead
  • Fixed timeouts on missing peers with libp2p
  • Add parallel peer forwarding when not enough peers for a sub-topic are present
  • Fixed attestation producer for a bunch of fucking annoying edge cases.

@Giulio2002 Giulio2002 enabled auto-merge (squash) October 22, 2024 20:59
domiwei
domiwei reviewed Oct 23, 2024
View reviewed changes
cl/beacon/handler/harness_test.go Outdated
beacontest.WithTestFromFs(Harnesses, "committees"),
beacontest.WithTestFromFs(Harnesses, "duties_attester"),
beacontest.WithTestFromFs(Harnesses, "duties_proposer"),
// beacontest.WithTestFromFs(Harnesses, "config"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm Did you intentionally comment out this test, or are you just wanting to skip it for the time being?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domiwei domiwei domiwei left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giulio2002 @domiwei