Parallel receipts root to ComputeCommitment
#12470
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giulio2002
force-pushed
the
parallel_receipts_root
branch
from
e145910
to
1e17425
Compare
| return fmt.Errorf("%w, txnIdx=%d, %v", consensus.ErrInvalidBlock, txTask.TxIndex, err) //same as in stage_exec.go | ||
| // This is an optimization to avoid running the post validation for every transaction in the block serially | ||
| // We only run it once for the last transaction in the block, this yields a +5% improvement in block processing time | ||
| if blockNum == maxBlockNum { |
There was a problem hiding this comment.
I don't understand this comment: every transaction in the block
- we are already in
txTask.Finalsection. so, how it can beevery transaction? if blockNum == maxBlockNumsays me that you probably meanevery block?+5% improvement in block processing time- even if you exec 1 block on chain tip?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve chain tip block times by around 3%