-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the ct_proper_ext
generators for the lists
property test suite
#7454
Use the ct_proper_ext
generators for the lists
property test suite
#7454
Conversation
Thanks for the PR! |
Will do, but I couldn't make it fail locally after a few tries. How often does this happen? Can I see the CT logs from the failed runs somewhere? |
Out of some 60-ish machines over the weekend (so ~200 runs), we only got the failures seen in the link below, so it's apparently pretty rare. https://gist.github.com/jhogberg/bdc8e457c3770ebabb21880d3cc80417 |
Ok, @juhlig found the problem (thanks 🤗), it is in the |
I fixed |
@jhogberg so, how's it looking? 🙂 |
It keeps on failing with similar errors :-( e.g.
|
Thanks. So that wasn't all there was to it... I'll see what I can find out. |
Btw, you're sure your tests are running on the updated code? I remember @bjorng had to remove and re-assign the |
Yes, |
Well, I'm lost ATM, can't reproduce the failures... have to think for a while 🤔 |
The problem seems to only pop up when one of the new generators is used in a PropEr-generated function, though... #7453 is having no failures, I guess? The new generators are used in there, too, but not with a function generator. |
#7453 looks okay over here. |
Ok, thanks :) |
ed0a7f5
to
32edfcb
Compare
@jhogberg so how's it looking today? (Sorry to bother you with this 😅) |
It looks good now, feel free to clean up the PR. :-) |
32edfcb
to
fa60596
Compare
Great 😃 Thanks for bearing with me through this debugging session 🤗 I removed the test commits from this PR and opened #7495 for it. When it is merged, I'll update this one and the others. |
fa60596
to
60118d8
Compare
Merged, thanks again for the PR! |
This PR changes the property test suite for the
lists
module to use the atomlimit-safe generators introduced withct_proper_ext
in #7364.Turns out it is not as easy as search-and-replace if workarounds were already in place 😅