-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate issues #218
Open
kyungilpark
wants to merge
11
commits into
es-analysis:master
Choose a base branch
from
kyungilpark:incorporate-issues
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Incorporate issues #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### REASON npm install fails on grunt-casper becauseof slimmerjs see iamchrismiller/grunt-casper#78 ### TODO I do not yet understand the intent of test-case that uses casper, so i'll rewrite test-case later with reference to old
### REASON vulnerability issue (es-analysis#216)
### REASON solve several es6 issues (es-analysis#214)
### REASON solve several eslint issues (es-analysis#166, es-analysis#211)
### REASON support `async/await` keywords (es-analysis#217) see jshint/jshint#3273 (comment)
cherry-pick and squash of es-analysis#200 by @JSlain - Fix Issue es-analysis#198 - Fix test
solved es-analysis#185 (redirecting stderr in shell)
- cherry-pick of es-analysis#187 by @sassy - solved es-analysis#182 - added test-case for es-analysis#182
- cherry-pick of es-analysis#219 by @SSANSH - Fix mkdir if folder exist - Bumping up node to 10.16.0
kyungilpark
force-pushed
the
incorporate-issues
branch
from
July 25, 2019 17:46
09b6f22
to
4f48f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solved most major issues and incorporated PRs
temporarily disabled grunt-casper (634982f)
#209 (comment)
see iamchrismiller/grunt-casper#78
npm audit fix (daa083c)
typhonjs-escomplex to 0.1.0 (5baa923)
eslint to latest and changing Linter to CLIEngine (fb8e298)
jshint to latest (7c7a112)
fix unexpected eslint error with eol-last rule (2c2e09c)
improve logger to call proper console api (2a06276)
Exception handling for
files
argument (e103408)Added file extensions option (597c9a6)
fix loading default jshintrc file (cdc5d5d)
TODO
Actually, i wanna replace
nodeunit+casper
withmocha+karma
html loads painfully slow
html loads painfully slow #181Because refactoring is required, a lot of effort is required.