Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix has_quote detection to handle free-form string values in header cards #421

Merged
merged 9 commits into from
Feb 20, 2025

Conversation

dstndstn
Copy link
Contributor

This fixes #420

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax?

@esheldon
Copy link
Owner

Thanks Dustin. Is there still an issue with the integer conversions?

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an entry into the changelog and then this one is good to go! Thank you!

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dstndstn
Copy link
Contributor Author

Thanks Dustin. Is there still an issue with the integer conversions?

Hah, oh yeah, what I thought was the original problem :) They get handled as intended: saved as strings.

QID     = '55700500000000071282' / 
QOBSEQID= '55301400000000319065' / 
QICSEQID= '55351200000000356039' / 
QOBITER =                   11 / 
QOFFID  = '10000000000000000001' / 

@beckermr beckermr merged commit 94595f1 into esheldon:master Feb 20, 2025
13 checks passed
@dstndstn
Copy link
Contributor Author

Thanks!!

@dstndstn dstndstn deleted the free-form-string branch February 20, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reading very large integer-looking values in headers
3 participants