When using file-level compression, allow setting compression parameters #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
legacypipe
code, we usemem://
files very extensively -- this allows us to do in-memory checksums before writing to disk.We also use compression extensively, which we set at the file level via extended filename syntax - eg we create files like
However, we find that when doing this, when you go to write an image HDU, the compression parameters don't get passed through because
compress=
is not set.This patch fixes that.
Test case: these two files should get the same
ZDITHER0
set.