-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add spi slave peripheral #617
base: develop
Are you sure you want to change the base?
Conversation
davideschiavone
commented
Jan 10, 2025
•
edited
Loading
edited
- Check compilation with Verilator
- Check compilation with Questasim
- Run test on simulation and check that it works
- Check FPGA synthesis
- Check FPGA with SPI Slave works
- Check ASIC flow
- Merge IP into its master repo replace AXI with OBI and remove QSPI obi_spi_slave#3
- Update vendor files
@@ -120,7 +120,7 @@ | |||
pdm2pcm: { | |||
offset: 0x00060000, | |||
length: 0x00010000, | |||
is_included: "no", | |||
is_included: "yes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuanSapriza can u pls revert this ?
@@ -612,29 +612,7 @@ module testharness #( | |||
.i2s_sd_o(gpio[22]) | |||
); | |||
|
|||
`ifndef VERILATOR | |||
// Flash used for booting (execute from flash or copy from flash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add back the flash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuanSapriza we should add back the FLASH on the spi flash master output, and remove the flash from the other spi_host peripheral (as now connected to spi slave).
Also, we should fix all the tests that uses the Flash via spi_host as this will be now only connected to spi slave.
Can you also add a bullet point on this topic for HEEPidermis?
Thx
Verification of SPI slave peripheral
Hello @davideschiavone thanks for the generous merge of my PR, but i will have to create another because i cannot push to this branch ahahahah |
set_property -dict {PACKAGE_PIN U13 IOSTANDARD LVCMOS33} [get_ports {gpio_io[13]}] ; # arduino_gpio_tri_io[2] | ||
set_property -dict {PACKAGE_PIN V13 IOSTANDARD LVCMOS33} [get_ports {gpio_io[14]}] ; # arduino_gpio_tri_io[3] | ||
|
||
# Tri-color LEDs for TARGET_PYNQ_Z2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuanSapriza , we should define the SPI_SLAVE clk as for the system clk, jtag, master clk, etc