Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spi slave peripheral #617

Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

add spi slave peripheral #617

wants to merge 20 commits into from

Conversation

davideschiavone
Copy link
Member

@davideschiavone davideschiavone commented Jan 10, 2025

  • Check compilation with Verilator
  • Check compilation with Questasim
  • Run test on simulation and check that it works
  • Check FPGA synthesis
  • Check FPGA with SPI Slave works
  • Check ASIC flow
  • Merge IP into its master repo replace AXI with OBI and remove QSPI obi_spi_slave#3
  • Update vendor files

@davideschiavone davideschiavone marked this pull request as draft January 10, 2025 07:46
@davideschiavone davideschiavone changed the title Add spi slave peripheral add spi slave peripheral Jan 10, 2025
@@ -120,7 +120,7 @@
pdm2pcm: {
offset: 0x00060000,
length: 0x00010000,
is_included: "no",
is_included: "yes",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanSapriza can u pls revert this ?

@@ -612,29 +612,7 @@ module testharness #(
.i2s_sd_o(gpio[22])
);

`ifndef VERILATOR
// Flash used for booting (execute from flash or copy from flash)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add back the flash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanSapriza we should add back the FLASH on the spi flash master output, and remove the flash from the other spi_host peripheral (as now connected to spi slave).

Also, we should fix all the tests that uses the Flash via spi_host as this will be now only connected to spi slave.

Can you also add a bullet point on this topic for HEEPidermis?

Thx

@davideschiavone davideschiavone changed the base branch from main to develop January 29, 2025 13:33
@davideschiavone davideschiavone self-assigned this Jan 29, 2025
@JuanSapriza
Copy link
Contributor

Hello @davideschiavone thanks for the generous merge of my PR, but i will have to create another because i cannot push to this branch ahahahah
I will be working on those changes and checking that the FPGA works with an external device. will add a separate example for spi_slave_from_external_device using and Arduino

set_property -dict {PACKAGE_PIN U13 IOSTANDARD LVCMOS33} [get_ports {gpio_io[13]}] ; # arduino_gpio_tri_io[2]
set_property -dict {PACKAGE_PIN V13 IOSTANDARD LVCMOS33} [get_ports {gpio_io[14]}] ; # arduino_gpio_tri_io[3]

# Tri-color LEDs for TARGET_PYNQ_Z2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuanSapriza , we should define the SPI_SLAVE clk as for the system clk, jtag, master clk, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants