Use amoc telemetry events to do logging #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NelsonVides
force-pushed
the
amoc_logging
branch
from
d792eda
to
6b3efc2
Compare
NelsonVides
force-pushed
the
amoc_logging
branch
from
6b3efc2
to
928cbd2
Compare
| @@ -31,6 +32,10 @@ | |||
| deprecated_function_calls, deprecated_functions | |||
| ]}. | |||
|
|
|||
| {overrides, [ | |||
There was a problem hiding this comment.
Because https://github.com/for-GET/jesse/blob/cf075d213ae9e9c54a748c93cc64d5350e646f9a/rebar.config#L11
and OTP26.1 throws warnings for matching on 0.0, as in the future +0.0 and -0.0 will not be considered equal anymore.
There was a problem hiding this comment.
please don't reset it completely, but rather just remove what is breaking build, and add the comment regarding this at rebar.config.
NelsonVides
force-pushed
the
amoc_logging
branch
from
9781849
to
97efcd4
Compare
DenysGonchar
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.