Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS related fixes #39

Closed
wants to merge 18 commits into from
Closed

DNS related fixes #39

wants to merge 18 commits into from

Conversation

arcusfelis
Copy link
Contributor

Check if DNS works fine before joining any nodes.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (2ca3105) 98.00% compared to head (c8d6780) 96.50%.

Files Patch % Lines
src/cets_discovery.erl 81.25% 9 Missing ⚠️
src/cets_ping.erl 90.90% 2 Missing ⚠️
src/cets_long.erl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   98.00%   96.50%   -1.50%     
==========================================
  Files           9       10       +1     
  Lines         652      716      +64     
==========================================
+ Hits          639      691      +52     
- Misses         13       25      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Do not call net_kernel to connect to a node, if its name is not resolvable
Do not disconnect from a node if ping fails
Add ping_pairs function
ping_pairs does not use net_adm:ping anymore
Do pings before sending any messages to new nodes
@arcusfelis
Copy link
Contributor Author

a different solution is introduced in #41 instead

@arcusfelis arcusfelis closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant