New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Schedule blog post #645

Merged

mdjermanovic merged 2 commits into main from schedule-rule-post

Oct 4, 2024

Member

nzakas commented Oct 2, 2024

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Schedule @captbaritone's blog post for next Tuesday.

Is there anything you'd like reviewers to focus on?

It should be safe to merge this ahead of time because we don't render future posts in production.


          feat: Schedule blog post

eb0b19c

eslint-github-bot bot added the feature label

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for new-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/new-eslint/deploys/66fffbe45a9ad60008c7bf6a
😎 Deploy Preview	https://deploy-preview-645--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/es-eslint/deploys/66fffbe42291080008b225a1
😎 Deploy Preview	https://deploy-preview-645--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/ja-eslint/deploys/66fffbe4aec24c0008bbb148
😎 Deploy Preview	https://deploy-preview-645--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/hi-eslint/deploys/66fffbe42a97c00008d70ce9
😎 Deploy Preview	https://deploy-preview-645--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/zh-hans-eslint/deploys/66fffbe4944c7700080a280e
😎 Deploy Preview	https://deploy-preview-645--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/fr-eslint/deploys/66fffbe4f1e57800082e2c10
😎 Deploy Preview	https://deploy-preview-645--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/pt-br-eslint/deploys/66fffbe4aec24c0008bbb14d
😎 Deploy Preview	https://deploy-preview-645--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify bot commented Oct 2, 2024 •

edited

Loading

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`41bbdc3`
🔍 Latest deploy log	https://app.netlify.com/sites/de-eslint/deploys/66fffbe58dd51b000817558f
😎 Deploy Preview	https://deploy-preview-645--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Contributor

captbaritone commented Oct 2, 2024

Post looks good to me! One thing I noticed is that even though I have an author bio defined in the repo (from my previous post) I don't see it used anywhere in this post. Is that expected?

Member

mdjermanovic commented Oct 3, 2024 •

edited

Loading

It should be safe to merge this ahead of time because we don't render future posts in production.

I tested this locally with CONTEXT=production environment variable, and:

The page is rendered and can be opened directly.
It doesn't appear in the list of blog posts on https://eslint.org/blog/, but it does appear in the list of blog posts on https://eslint.org/blog/category/case-studies/.
It appears in sitemap.xml.

Maybe we should fix this before merging? PR: #646

Member

mdjermanovic commented Oct 3, 2024 •

edited

Loading

One thing I noticed is that even though I have an author bio defined in the repo (from my previous post) I don't see it used anywhere in this post. Is that expected?

Author bio is at the end of the blog post:

https://deploy-preview-645--new-eslint.netlify.app/blog/2024/10/code-review-nit-to-ecosystem-improvements/#conclusion

mdjermanovic mentioned this pull request

fix: Don't deploy future blog posts in production #646

Merged

1 task


          Recategorize as Storytime

41bbdc3

Member Author

nzakas commented Oct 4, 2024

Now that #646 is merged, I think it should be safe to merge this?

We do a nightly data fetch to regenerate the site, so I think this will get automatically published on Tuesday.

Member

mdjermanovic commented Oct 4, 2024

Now that #646 is merged, I think it should be safe to merge this?

Yes, I'll merge it now and check the build log and the site.

We do a nightly data fetch to regenerate the site, so I think this will get automatically published on Tuesday.

It should be as there's always some change in the data. I'll doublecheck on Tuesday.

mdjermanovic approved these changes

View reviewed changes

mdjermanovic merged commit beed0b1 into main

37 checks passed

mdjermanovic deleted the schedule-rule-post branch

October 4, 2024 15:24

Member

mdjermanovic commented Oct 4, 2024

Works fine:

5:25:12 PM: > npx @11ty/eleventy
5:25:13 PM: Ignoring future blog post src/content/blog/2024-10-08-code-review-nit-to-ecosystem-improvements.md
5:25:16 PM: [11ty] Writing _site/feed.xml from ./src/static/feed.njk
...

And https://eslint.org/blog/2024/10/code-review-nit-to-ecosystem-improvements/ doesn't exist yet.

Member

mdjermanovic commented Oct 8, 2024

The blog post is published now:

https://eslint.org/blog/

https://eslint.org/blog/2024/10/code-review-nit-to-ecosystem-improvements/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels