No size limit for received server output JSON #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
|
Thanks for the pull request! We should definitely fix this. |
davidBar-On
force-pushed
the
JSON_read-check-JSON-size
branch
from
36fff3c
to
464ce7c
Compare
|
Hi David! Thank you for the pull request! I have confirmed this seems to remove the issue of the overflow on ubuntu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): If -P, --get-server-output, and -J options are specified on the client side, measurement is not performed correctly. #1776
Brief description of code changes (suitable for use as a commit message):
Fix PR #1709 that did not take into account reading JSON for
--get-server-output. Now limiting the received JSON size only when reading parameters. Size is not limited for receiving server output JSON.