Stop TTS Response #162
Merged
Stop TTS Response #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
|
Firmware built successfully! 🎉 Download and extract the firmware to install with https://web.esphome.io Make sure to choose |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 things happening in this PR
1. You can stop TTS with the
stopwordThe
stopword is activated only after 1 second as per Mike's recommendation to avoid messing with AEC.2. I finally fixed the error state
When the voice assistant encounters an error, we want to display a temporary error state for 1 second.
I was doing this
on_errorbut the voice assistant ends almost instantaneously afteron_error.So the error state was never really displayed.
Now the 1s delay is handled correctly.
3. Saying a wake word when the TTS is playing back does not start the pipeline anymore.
That was kind of a hack.
Since we did not have a
stopword, when the media player was announcing, and micro_wake_word was triggered, I stopped the announcement and started a new pipeline.Now that we have a
stopword, I decided to simplify this part.If the media player is announcing, and micro_wake_word is triggered - I stop the announcement and that is it.
So long TTS response >>>
stop>>> TTS stops. (And that's it - Nothing restarts)4. I reworked ever so slightly the Timer Tick effect
I did not like the hack I put in place for when the LED ring was full.
Now, one LED dips in brightness for the whole duration of the timer (in a rotating manner)
Because it happens the whole duration of the timer, the brightness dip is more subtle, barely noticeable