Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LED glitching #308

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Fix LED glitching #308

merged 3 commits into from
Feb 19, 2025

Conversation

kbx81
Copy link
Member

@kbx81 kbx81 commented Jan 23, 2025

SSIA

This change seems to resolve the intermittent LED glitching seen in certain modes (such as when the device is muted).

Note that this fix requires the RMT changes merged after the 2024.12 release.

Also removes unnecessary redundant flash_mode parameter now that we've switched to IDF 5+.

@kbx81 kbx81 marked this pull request as draft January 23, 2025 10:36
@kbx81
Copy link
Member Author

kbx81 commented Jan 23, 2025

Leaving this marked as a draft until the next ESPHome release.

@jlpouffier
Copy link
Contributor

Ouuuuuh i'm excited

jesserockz
jesserockz previously approved these changes Jan 24, 2025
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go after ESPHome 2025.2.0 is released

@tbrasser
Copy link

tbrasser commented Feb 14, 2025

Can it go to dev during esphome betas? (Feeling this might fix #324)

@kahrendt kahrendt marked this pull request as ready for review February 19, 2025 16:43
Copy link

Firmware built successfully! 🎉

Download and extract the firmware to install with https://web.esphome.io

Make sure to choose home-assistant-voice-esp32s3.factory.bin.

@kahrendt kahrendt merged commit ba4fca5 into dev Feb 19, 2025
11 checks passed
@kahrendt kahrendt deleted the 20250123-led-glitching-fix branch February 19, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants