Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changing the media player's name #333

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Revert changing the media player's name #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion home-assistant-voice.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,7 +1432,7 @@ speaker:
media_player:
- platform: speaker
id: external_media_player
name: None
name: Media Player
Copy link

@marcelveldt marcelveldt Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not the name causing this, but the id nvm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/esphome/aioesphomeapi/blob/7c864eafbd9b0983b6b90c00da156fb5beee4902/aioesphomeapi/model.py#L1399

looks like it is the ID ?

internal: False
volume_increment: 0.05
volume_min: 0.4
Expand Down
Loading