-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ble/bluedroid): Don't log error on 16/128-bit UUID mixed descriptors (IDFGH-14175) #14975
base: master
Are you sure you want to change the base?
Conversation
👋 Hello nebkat, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
e9abb62
to
7cce143
Compare
Your commit has been merged into the master branch, but it will take some time to sync to GitHub. Additionally, your commit will also be synced to the release branch, which will also take some time. Please note that the final changes may not be exactly the same as your original modifications, as I have made some optimizations to conform to coding standards. However, your commit information has been retained. Thank you for your contribution! Here are the details: |
Description
If multiple descriptors are defined for a characteristic where there is a mix of 16-bit and 128-bit UUIDs, an error log was printed during the discovery process.
As per
BLUETOOTH CORE SPECIFICATION Version 5.4 | Vol 3, Part F
pages 1419/1420:In other words, if we start returning 16-bit UUID attributes and we encounter 128-bit (or vice-versa) we should simply return what we have so far, and the client should send a new
ATT_FIND_INFORMATION_REQ
. There is no need for the error log.Also, interestingly, the return code is ignored anyway:
esp-idf/components/bt/host/bluedroid/stack/gatt/gatt_sr.c
Lines 1016 to 1020 in 030c995
Checklist
Before submitting a Pull Request, please ensure the following: