-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(esp_hid): Implement SDK Config BTC/BLE Task Size (IDFGH-14561) #15320
base: master
Are you sure you want to change the base?
Conversation
mitchellcairns
commented
Feb 2, 2025
- Implement Kconfig task size parameters for BLE/BTC tasks
- esp_hid task requires user-defined callbacks, and limiting this with a constant value is generally a bad idea for events that require immediate handling (Gamepads are a good example, handing this data off with a queue adds too much latency)
- Implement Kconfig task size parameters for BLE/BTC tasks - esp_hid task requires user-defined callbacks, and limiting this with a constant value is generally a bad idea for events that require immediate handling.
👋 Hello mitchellcairns, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hi @mitchellcairns, Thank you for your contribution! We appreciate your efforts in implementing configurable task sizes for ESP HID. We have reviewed your changes and will accept the code. However, to maintain compatibility with older versions, we will set the following default values:
Please let us know if you have any concerns regarding these default values. |
Looks fine to me. Thank you! |
Your commit has been merged into the master branch, but it will take some time to sync to GitHub. Additionally, your commit will also be synced to the release branch, which will also take some time. Please note that the final changes may not be exactly the same as your original modifications, as I have made some optimizations to conform to coding standards. However, your commit information has been retained. Thank you for your contribution! Here are the details: |