Improve PPP netif server support (IDFGH-14720) #15459
Open
+63
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous introduction of server support was a nice addition, improve this by making it easier to run both a PPP server and PPP client on different interfaces.
Note that if CONFIG_LWIP_PPP_SERVER_SUPPORT=y and ppp_passive isn't set the code will call ppp_connect() instead of ppp_listen(). However, ppp_connect() and ppp_listen() are the same for pppos so it shouldn't matter.
For PPPoE ppp_listen() isn't really supported.
Related
Testing
Tested with PPP over serial as server and esp-modem for uplink.
Checklist
Before submitting a Pull Request, please ensure the following: