Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PPP netif server support (IDFGH-14720) #15459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gonzzor
Copy link

@gonzzor gonzzor commented Feb 24, 2025

Description

The previous introduction of server support was a nice addition, improve this by making it easier to run both a PPP server and PPP client on different interfaces.

Note that if CONFIG_LWIP_PPP_SERVER_SUPPORT=y and ppp_passive isn't set the code will call ppp_connect() instead of ppp_listen(). However, ppp_connect() and ppp_listen() are the same for pppos so it shouldn't matter.

For PPPoE ppp_listen() isn't really supported.

Related

Testing

Tested with PPP over serial as server and esp-modem for uplink.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Feb 24, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello gonzzor, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 7326fe3

@github-actions github-actions bot changed the title Improve PPP netif server support Improve PPP netif server support (IDFGH-14720) Feb 24, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 24, 2025
Make it possible to set the DNS servers to provide to the peer. This is
useful when acting as a PPP server.

If any DNS server is set, don't request a DNS server from the peer.
Make it easier to run a PPP server and client on different interfaces by
adding the interface name to logs and expose the PPP passive option.

The addition of IP_EVENT_PPPD_{GOT,LOST}_IP events make it possible
differentiate between client and server events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants