-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daisy Clock Display 12hrs, 5% ring Increments and Settings to Change the Ring Behavior #3759
Draft
voloved
wants to merge
25
commits into
espruino:master
Choose a base branch
from
voloved:daisy_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks, LGTM! @hughbarney are you happy for this to be merged? |
Actually, hang on, I want to make the Sunrise and Sunset time remaining an option on the wheel and make those times show as 12 hours as well. |
I'll pop this into draft - if you put it back to ready when you're happy I can look at merging :) |
6ca1590
to
2e563f8
Compare
a3bbbd0
to
1732510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the Daisy watch behavior by:
The ring options and the 12hr mode are both options in the Settings.
The only new concerns from this change are:
Seconds
option will drain the watch faster, as it'll update the face every 5 seconds, rather than every minutesBattery
option may cause the Ring to pop due to lack of deadband, As in, if the battery jumps between 50% and 51% continuously, the ring will jump between the two each minute. This is unlikely to be a concern, but I wanted to point it out.I tested all of the new settings on a Bangle2, and they all work well. The
Seconds
option confirmed that all of the 5% ring steps looked good as well.