Add Get Current Address App #3761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit, v0.1
add app image
bobrippling
reviewed
Feb 27, 2025
apps/getaddr/getaddr.app.js
Outdated
| function getStreetAndHouseNumber(lat, lon) { | ||
| const url = `${nominatimApi}/reverse`; | ||
| const paramsStr = Object.keys(params).map(key => `${key}=${encodeURIComponent(params[key])}`).join('&'); | ||
| const fullUrl = `${url}?${paramsStr}&lat=${lat}&lon=${lon}&accept-language=de&format=json`; |
There was a problem hiding this comment.
Should we configure this based on the user's language?
Suggested change
| const fullUrl = `${url}?${paramsStr}&lat=${lat}&lon=${lon}&accept-language=de&format=json`; | |
| const fullUrl = `${url}?${paramsStr}&lat=${lat}&lon=${lon}&accept-language=${lang}&format=json`; |
@gfwilliams do we have a way of getting the language name from locale? I can't find any atm
There was a problem hiding this comment.
What about
>require("locale").name # "de_DE"
const lang = require("locale").name.substring(0, 2)
There was a problem hiding this comment.
I have updated the PR with your suggestion.
There was a problem hiding this comment.
Somehow I didn't spot name - nice.
One thing to note is that the default might be "system", perhaps we detect that and fallback to a default such as "de" or "en" ?
There was a problem hiding this comment.
Good point. I have updated the PR.
Dynamically get device language
Add fallback for "system" language
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the "Get Current Address App"
It uses the GPS and compass capabilities of the Bangle.js 2 watch to display your current location and direction.