Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 650: add Custom to DriverID enum #665

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Issue 650: add Custom to DriverID enum #665

merged 3 commits into from
Jan 22, 2025

Conversation

jkotan
Copy link
Collaborator

@jkotan jkotan commented Jan 20, 2025

It resolves #650 by adding DriverID::Custom = 0

@jkotan jkotan requested review from yuelongyu and ggoneiESS January 22, 2025 14:14
Copy link
Member

@ggoneiESS ggoneiESS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jkotan jkotan merged commit 8f8a962 into master Jan 22, 2025
56 of 58 checks passed
@jkotan jkotan deleted the issue_650 branch January 22, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add custom drivers non-intrusively?
2 participants