Update to Xcode 15.0.1 / iOS 17.0.1 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection(mutations:)`
caiozullo
force-pushed
the
xcode15_0
branch
from
79e2091 to
5ea99b0
Compare
…r's `viewIsAppearing` lifecycle method - This change is needed since UIRefreshControl updates must happen when the view is on-screen on iOS17+ (it ignores updates otherwise!). - `viewDidLoad` is called once per VC, but the new `viewIsAppearing` may be called multiple times - so we added logic to ensure the refresh only happens in the first `viewIsAppearing` occurrence to mimic the previous behavior in `viewDidLoad`. - When running tests, the views are never added on-screen, so UIRefreshControl doesn't work as expected on iOS 17+. To allow testability, we replace the UIRefreshControl with a FakeUIRefreshControl test-double.
caiozullo
changed the title
caiozullo
force-pushed
the
xcode15_0
branch
2 times, most recently
from
4c0d56f to
0b310f9
Compare
caiozullo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.