Fix issue #260: smarter rendering of array elements across lines

[dnkolegov]

The fix is based on discussion and suggestion in #260.

[michaelficarra]

!isPattern && expr.elements.length > 10 && expr.elements[0].type !== Syntax.Literal

[dnkolegov]

Do you mean this?

multiline = isPattern ? false : !isPattern && expr.elements.length > 10 && expr.elements[0].type !== Syntax.Literal;

isPattern in this is false and !isPattern is true.

[michaelficarra]

I don't like this approach. It is a rough approximation which may be very incorrect for certain inputs. The solution I suggested in #260 would actually solve this. 👎

[dnkolegov]

Hi @michaelficarra. Thanks for suggestion.

this can be done by determining the formatting based on the size/content of the generated source text for each element

Could you make clear what do you mean here? What content should be outputted across lines except Literal elements? And how I can determine size of source?

What about the following:

multiline = isPattern ? false : expr.elements.length > 10 && expr.elements[0].type !== Syntax.Literal && expr.elements[expr.elements.length - 1].type !== Syntax.Literal;

[michaelficarra]

@dnkolegov The suggestion I had was to split across lines based on the length of the result of calling generateExpression on the array elements. Closing this, as it's not making a decision based on a useful characteristic of the array.

[michaelficarra]

@healzer Feel free to implement it and send a PR.