Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for utility.js #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add tests for utility.js #16

wants to merge 2 commits into from

Conversation

ThomasR
Copy link
Contributor

@ThomasR ThomasR commented Feb 27, 2016

No description provided.


describe 'generateNextName:', ->
it 'generates names', ->
#XXX not valid identifiers - should we disallow these input values by throwing an error?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, do not disallow them, but it should be undefined behaviour, so remove the next 4 tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the implementation relies on generateNextName('9') === 'a'

name = '9';

tip = '9';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants