Phil/resource path pointers #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mdibaiee
reviewed
Nov 29, 2023
| @@ -261,6 +259,7 @@ mod test { | |||
| resource_config_json: "{}".to_string(), | |||
| collection: None, | |||
| field_config_json_map: BTreeMap::new(), | |||
| backfill: 7, | |||
There was a problem hiding this comment.
The backfill field was added to the protocol recently (estuary/flow#1276). I had to add it here because I updated the proto-flow dependency.
psFried
force-pushed
the
phil/resource-path-pointers
branch
from
64f34ec
to
3ef74f8
Compare
This allows these connectors to take advantage of the new discover merge behavior.
psFried
force-pushed
the
phil/resource-path-pointers
branch
from
3ef74f8
to
a920095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of estuary/flow#1285. It updates the airbyte connectors to use the new approach for merging discovered bindings, based on
resource_path_pointers.