Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estuary-cdk: common.ConnectorState is generic #1309

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

jgraettinger
Copy link
Member

@jgraettinger jgraettinger commented Mar 4, 2024

Use GenericModel to support v1 pydantic polyfill.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

Use GenericModel to support v1 pydantic polyfill.
@jgraettinger jgraettinger requested a review from a team March 4, 2024 20:07
Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit dcdddd5 into main Mar 4, 2024
48 of 52 checks passed
@jgraettinger jgraettinger deleted the johnny/cdk-generic branch March 4, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants