Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-gladly: use BaseModel for Event Model nested objects #1324

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Mar 5, 2024

Description:

BaseDocument includes _meta fields which we don't want for the nested objects of Event, so use BaseModel instead.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

BaseDocument includes _meta fields which we don't want for the nested objects of Event, so use
BaseModel instead.
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit 75d96c4 into main Mar 5, 2024
50 of 53 checks passed
@williamhbaker williamhbaker deleted the wb/gladly-no-meta branch March 5, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants