Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make usage_rate a string in matrix definition #1346

Merged
merged 3 commits into from
Mar 8, 2024
Merged

ci: make usage_rate a string in matrix definition #1346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7901589
ci: make usage_rate a string in matrix definition
psFried Mar 8, 2024
d8cdd70
ci: cosmetic change to get ci to run
psFried Mar 8, 2024
7ab27a2
ci: fix passing usage_rate build arg to python connectors
psFried Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,19 @@ jobs:
- name: source-asana
type: capture
version: v1
usage_rate: 1.0
usage_rate: "1.0"
- name: source-hubspot-native
type: capture
version: v1
usage_rate: 1.0
usage_rate: "1.0"
- name: source-gladly
type: capture
version: v1
usage_rate: 1.0
usage_rate: "1.0"
- name: source-google-sheets-native
type: capture
version: v1
usage_rate: 0.0
usage_rate: "0.0"

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
build-args: |
CONNECTOR_NAME=${{ matrix.connector.name }}
CONNECTOR_TYPE=${{ matrix.connector.type }}
USAGE_RATE=${{ matrix.usage_rate }}
USAGE_RATE=${{ matrix.connector.usage_rate }}
tags: ghcr.io/estuary/${{ matrix.connector.name }}:local

- name: Deployment
Expand Down
2 changes: 1 addition & 1 deletion estuary-cdk/common.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ ARG USAGE_RATE

LABEL FLOW_RUNTIME_PROTOCOL=${CONNECTOR_TYPE}
LABEL FLOW_RUNTIME_CODEC=json
LABEL dev.estuary.usage-rate=$USAGE_RATE
LABEL dev.estuary.usage-rate=${USAGE_RATE}

COPY --from=builder /opt/$CONNECTOR_NAME /opt/$CONNECTOR_NAME
COPY --from=builder /opt/estuary-cdk /opt/estuary-cdk
Expand Down
Loading