Adding source-mailchimp connector #1536
Conversation
…292a259f4daf43 Remote Repo URL: https://github.com/airbytehq/airbyte.git Source name: 45dae2c2485b9c7f90db83a106292a259f4daf43 Source Commit ID: 45dae2c2485b9c7f90db83a106292a259f4daf43 Source Repo Prefix: airbyte-integrations/connectors/source-mailchimp/ Import Path: source-mailchimp/ License Type: MIT License Path: airbyte-integrations/connectors/source-mailchimp/pyproject.toml git-merge-subpath: 45dae2c2485b9c7f90db83a106292a259f4daf43 airbyte-integrations/connectors/source-mailchimp source-mailchimp
Luishfs
force-pushed
the
luis/source-mailchimp
branch
from
678e367
to
df24d5a
Compare
|
@williamhbaker Mailchimp is ready for review. Discovery jsondiff is a bit large ( due to some changes on schema & new streams ), let me know if you need me to do something to help in review |
|
Can you verify that that the patches in https://github.com/estuary/airbyte/tree/master/airbyte-integrations/connectors/source-mailchimp have been applied on this import, if applicable? Particularly the ones in https://github.com/estuary/airbyte/tree/master/airbyte-integrations/connectors/source-mailchimp/streams. I'm seeing for example that https://github.com/estuary/airbyte/blob/master/airbyte-integrations/connectors/source-mailchimp/streams/campaigns.patch.json has not been carried over, and I'm wondering why that is? |
Luishfs
force-pushed
the
luis/source-mailchimp
branch
from
208f427
to
8f41f13
Compare
|
@williamhbaker Made the changes to b674a29 and updated jsondiff links. This change seemed to not make any difference when running capture or end-to-end tests, also it seems to be plenty of |
|
@williamhbaker just addressed it, waiting for tests to confim. |
…s/source-mailchimp
Notes for reviewers:
Discover
Discover jsondiff
Capture
Capture jsondiff
Spec
Spec jsondiff
End-To-End
End-to-End tests were validated using a local flow setup with a hosted supabase db
This change is