Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models: quoted_* methods return str, not bool #2009

Merged
merged 1 commit into from
Oct 2, 2024
Merged

models: quoted_* methods return str, not bool #2009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source-oracle-flashback/source_oracle_flashback/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class Type(StrEnum):
nullable: bool = Field(default=True, alias="NULLABLE")

@computed_field
def quoted_column_name(self) -> bool:
def quoted_column_name(self) -> str:
return quote_identifier(self.column_name)

@computed_field
Expand Down Expand Up @@ -253,11 +253,11 @@ class Table:
model_fields: dict[str, Any]

@computed_field
def quoted_owner(self) -> bool:
def quoted_owner(self) -> str:
return quote_identifier(self.owner)

@computed_field
def quoted_table_name(self) -> bool:
def quoted_table_name(self) -> str:
return quote_identifier(self.table_name)

def create_model(self) -> type[Document]:
Expand Down
Loading