Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot-native: add more email event types #2066

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Alex-Bair
Copy link
Contributor

@Alex-Bair Alex-Bair commented Oct 18, 2024

Description:

We've encountered even more email event types and need to expand the model to include them. Relevant HubSpot docs are here.

Interestingly, the SUPPRESSED type isn't documented in HubSpot's docs but we have seen it used in existing records. The similarly named SUPPRESSION type is listed in the docs; I'm not sure if this is a typo on HubSpot's end, or if they have an undocumented SUPPRESSED type. If it turns out SUPPRESSION is a HubSpot typo, we can remove it later.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

We've encountered even more email event types and expand the model to
include them.

Interestingly, the `SUPPRESSED` type isn't documented in HubSpot's docs
but we have seen it used in existing records. The similarly named
`SUPPRESSION` type is listed in the docs; I'm not sure if this is a typo
on HubSpot's end, or if they have an undocumented `SUPPRESSED` type. If
it turns out `SUPPRESSION` is a HubSpot typo, we can remove it later.
@Alex-Bair Alex-Bair added the change:unplanned Unplanned change, useful for things like doc updates label Oct 18, 2024
Copy link
Member

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Bair Alex-Bair merged commit 2d18e9f into main Oct 18, 2024
72 of 77 checks passed
@Alex-Bair Alex-Bair deleted the bair/hubspot-native-add-more-email-event-types branch October 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants