source-hubspot-native: search API breaks out of cycles with more than 10k records #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 10k records There is an undocumented failure of the search API when trying to page beyond 10,000 results. It's also possible that there are more than 10,000 records modified at the same time. Previously the only way out of this was to re-backfill the binding. This adds a cycle-breaker routine that walks ids in ascending order that were all modified at the exact same time to avoid looping forever.
williamhbaker
force-pushed
the
wb/hsn-10k-breaker
branch
from
604cec8
to
7674485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There is an undocumented failure of the search API when trying to page beyond 10,000 results. It's also possible that there are more than 10,000 records modified at the same time.
Previously the only way out of this was to re-backfill the binding. This adds a cycle-breaker routine that walks ids in ascending order that were all modified at the exact same time to avoid looping forever.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is