source-genesys: add discriminator to endpoint config's credentials #2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, wrap the `ClientCredentialsOAuth2Credentials` class in a more user-friendly name since it shows up in the UI. There's likely a more elegant & correct solution to fix this, but I haven't found it yet.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes include:
discriminatorto the endpoint config'scredentialsso it's easier to add more authentication methods later if needed.ClientCredentialsOAuth2Credentialsclass in a more user-friendly name since it shows up in the UI somehow. There's likely a more elegant & correct solution to fix this, but I haven't found it yet.After these changes, the UI looks like the below:
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Spec snapshot updates are expected since the endpoint config has changed. There is no real use of the connector yet, so there are no existing tasks affected by these changes.
This change is