Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materialize-databricks: fix commit logging for split queries #2199

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Dec 12, 2024

Description:

Databricks Store queries may be split into multiple separate items for large file sizes. This fixing the logging so that the started / ending commit messaging is not emitted for each of the split queries, but rather for the entire binding.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

Databricks Store queries may be split into multiple separate items for large
file sizes. This fixing the logging so that the started / ending commit
messaging is not emitted for each of the split queries, but rather for the
entire binding.
Copy link
Contributor

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit 418f8e5 into main Dec 12, 2024
52 of 53 checks passed
@williamhbaker williamhbaker deleted the wb/dbricks-commit-logging branch December 12, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants