Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-oracle-flashback: raise query errors that aren't ORA-30052 #2200

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Dec 12, 2024

Description:

We were swallowing errors from queries that weren't caused by ORA-30052. This fixed that by raising exceptions that can't be automatically fixed by a backfill.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

We were swallowing errors from queries that weren't caused by ORA-30052. This
fixed that by raising exceptions that can't be automatically fixed by a
backfill.
Copy link
Contributor

@Alex-Bair Alex-Bair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The prior ec2 instance had become unreachable, so I created a new one and
updated the test configuration.
@williamhbaker williamhbaker merged commit 9dc7388 into main Dec 12, 2024
74 of 79 checks passed
@williamhbaker williamhbaker deleted the wb/oracle branch December 12, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants