Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-oracle-flashback: debug logs in backfill #2227

Merged
merged 1 commit into from
Dec 23, 2024
+4 −1
Merged

source-oracle-flashback: debug logs in backfill #2227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source-oracle-flashback/source_oracle_flashback/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,12 +212,15 @@ async def fetch_page(

i += 1
if i % CHECKPOINT_EVERY == 0:
log.debug("emitting checkpoint at CHECKPOINT_EVERY", i, "last_rowid", last_rowid)
yield last_rowid

if c.rowcount < backfill_chunk_size:
log.debug("had less than backfill_chunk_size documents", c.rowcount, "last_rowid", last_rowid)
break

if last_rowid is not None and (i % CHECKPOINT_EVERY) != 0:
log.debug("emitting final checkpoint of backfill", last_rowid, "total documents", i)
yield last_rowid

op_mapping = {
Expand Down
2 changes: 1 addition & 1 deletion source-oracle-flashback/source_oracle_flashback/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ async def tables_to_resources(
break

for (i, t) in enumerate(tables):
# if max_rowid is None, that maens there are no rows in the table, so we
# if max_rowid is None, that means there are no rows in the table, so we
# skip backfill

backfill = ResourceState.Backfill(cutoff=(max_rowids[i],)) if max_rowids[i] is not None else None
Expand Down
Loading