source-oracle-flashback: order first, then limit row count #2229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ROWNUM
to limit the number of rows, but that filter is applied before ordering, and that would lead to inconsistencies if ROWIDs were not in the order of insertion (sometimes ROWIDs can be reused if they have been freed up due to deletion / resize of data in data segments), a common pitfall ofROWNUM
filtering which I fell forROWNUM
filtering we can useFETCH NEXT %d ROWS ONLY
which has been introduced in Oracle 12c (released 2013). An alternative implementation is using a subquery likeSELECT * FROM (SELECT ...) WHERE ROWNUM < 50000
for older versions, but I'm not sure about its performance implications, and after talking with Dave we haven't had customers ask for Oracle versions below 12c yet. I put a note in the code for that so we can revisit if necessary.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is