materialize-databricks: debugging logs for duplicates #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
approved these changes
Jan 9, 2025
| Max: converted[0], | ||
| } | ||
| } else { | ||
| switch v := converted[0].(type) { |
There was a problem hiding this comment.
See here for what I believe are the full set of types that keys can take. They might be encoded uint64, or possibly float64 (not 100% sure on that) if the otherwise-integer values are really big.
materialize-databricks/driver.go
Outdated
|
|
||
| } | ||
|
|
||
| var binding = d.bindingForStateKey(stateKey) |
There was a problem hiding this comment.
You might run this both before and after the Store query is run, that way we can tell if there were already duplicates in the table before our query ran.
mdibaiee
force-pushed
the
mahdi/databricks-debug
branch
from
5826c64 to
b04dbcd
Compare
mdibaiee
force-pushed
the
mahdi/databricks-debug
branch
from
b04dbcd to
0c30954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is