source-firestore: Increase re-backfill period from 6h to 24h #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically the whole "we have to go re-backfill the collection because it's inconsistent" thing only triggers on massive collections which are likely to fail again in the future, _and_ Firestore is really an expensive datastore, so having a default of re-backfilling these collections at most once per day is a nontrivial cost savings. I'm taking the simplest, dumbest possible route here and just changing the existing hard-coded constant from 6 to 24 hours. I'd like to go and make this user-configurable at some point, but that's actually more complicated than it seems because of how multiple bindings can share a collection ID and thus fail and need restarting as a group.
willdonnelly
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Typically the whole "we have to go re-backfill the collection because it's inconsistent" thing only triggers on massive collections which are likely to fail again in the future, and Firestore is really an expensive datastore, so having a default of re-backfilling these collections at most once per day is a nontrivial cost savings.
I'm taking the simplest, dumbest possible route here and just changing the existing hard-coded constant from 6 to 24 hours.
I'd like to go and make this user-configurable at some point, but that's actually more complicated than it seems because of how multiple bindings can share a collection ID and thus fail and need restarting as a group.
This fixes #2250
This change is