sourceCapture: error when setting targetSchema without x-schema-name

estuary · Sep 25, 2024 · 9b298a3 · 9b298a3
1 parent cee8ef4
commit 9b298a3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/crates/agent/src/controllers/materialization.rs b/crates/agent/src/controllers/materialization.rs
@@ -66,7 +66,7 @@ impl MaterializationStatus {
                 dependencies.live.captures.get_by_key(&source_capture.capture_name())
             {
                 if self.source_capture.is_none() {
-                    self.source_capture = Some(SourceCaptureStatus::default())
+                    self.source_capture = Some(SourceCaptureStatus::default());
                 }
                 let source_capture_status = self.source_capture.as_mut().unwrap();
                 // Source capture errors are terminal

diff --git a/crates/agent/src/resource_configs.rs b/crates/agent/src/resource_configs.rs
@@ -44,6 +44,10 @@ pub fn update_materialization_resource_spec(
                     "cannot create location '{x_schema_name_ptr}' in resource spec '{resource_spec}'"
                 );
             }
+        } else {
+            anyhow::bail!(
+                "sourceCapture.targetSchema set on a materialization which does not have x-schema-name annotation"
+            );
         }
     }
 
@@ -56,6 +60,10 @@ pub fn update_materialization_resource_spec(
                     "cannot create location '{x_delta_updates_ptr}' in resource spec '{resource_spec}'"
                 );
             }
+        } else {
+            anyhow::bail!(
+                "sourceCapture.deltaUpdates set on a materialization which does not have x-delta-updates annotation"
+            );
         }
     }