dekaf: Track latest committed offset by group and journal #1715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this:
In order to correlate this with the
journal:gazette_write_head:max
metric, we need the exact journal name. Unfortunately, Kafka only represents topic partitions by their index, so in order to expose a useful metric we have to go and look up the exact journal name given the collection name and partition index. Fortunately,OffsetCommit
is a fairly infrequent API call, and is not expected to respond particularly quickly, so I don't see this as a huge issue. If it is, we could cache this mapping from the various places it's fetched elsewhere.This change is